Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: make meta mutator part of jobContext #56399

Merged
merged 4 commits into from
Sep 29, 2024
Merged

ddl: make meta mutator part of jobContext #56399

merged 4 commits into from
Sep 29, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

  • make meta mutator part of jobContext to avoid passing everywhere
  • move job logger from worker to jobContext

Check List

Tests

  • Unit test. existing tests should cover it, we only move method parameter location
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 29, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 29, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter changed the title ddl: make meta mutator part of jobContext to avoid passing everywhere ddl: make meta mutator part of jobContext Sep 29, 2024
@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Sep 29, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter mentioned this pull request Sep 29, 2024
Open
54 tasks
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2024
@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Sep 29, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Sep 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.49838% with 34 lines in your changes missing coverage. Please review.

Project coverage is 76.0173%. Comparing base (dffc0c9) to head (f36d122).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56399        +/-   ##
================================================
+ Coverage   73.3936%   76.0173%   +2.6237%     
================================================
  Files          1623       1645        +22     
  Lines        447138     455363      +8225     
================================================
+ Hits         328171     346155     +17984     
+ Misses        98874      87590     -11284     
- Partials      20093      21618      +1525
Flag Coverage Δ
integration 51.9522% <80.0970%> (?)
unit 72.4807% <91.5857%> (-0.0050%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 62.9567% <ø> (+17.4128%) ⬆️

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-29 05:42:36.672710815 +0000 UTC m=+160712.092923822: ☑️ agreed by lance6716.
  • 2024-09-29 07:45:42.733006028 +0000 UTC m=+168098.153219040: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit 3922a4b into pingcap:master Sep 29, 2024
24 of 25 checks passed
@D3Hunter D3Hunter deleted the jobctx-txn branch September 29, 2024 07:50
EricZequan pushed a commit to EricZequan/tidb that referenced this pull request Sep 29, 2024
@D3Hunter @EricZequan
ddl: make meta mutator part of jobContext (pingcap#56399)
20326cc 
ref pingcap#54436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D3Hunter @lance6716 @wjhuang2016